現(xiàn)在我要對getCharge()實(shí)施Move Method(142).下面是重構(gòu)前的代碼：
class Movie...
double getCharge(int daysRented) {
double result = 0;
switch(getPriceCode()) { //取得影片出租價(jià)格
case Movie.REGULAR: //普通片
result+= 2;
if(getDaysRented() > 2)
result+= (getDaysRented() - 2) * 1.5;
break;
case Movie.NEW_RELEASE: //新片
result+= getDaysRented() * 3;
break;
case Movie.CHILDRENS: //兒童片
result+= 1.5;
if(getDaysRented() > 3)
result+= (getDaysRented() - 3) * 1.5;
break;
}
return result;
}
搬移動作很簡單。下面是重構(gòu)后的代碼：
class Movie...
double getCharge(int daysRented) {
return _price.getCharge(daysRented);
}
class Price...
double getCharge(int daysRented) {
double result = 0;
switch(getPriceCode()) { //取得影片出租價(jià)格
case Movie.REGULAR: //普通片
result+= 2;
if(getDaysRented() > 2)
result+= (getDaysRented() - 2) * 1.5;
break;
case Movie.NEW_RELEASE: //新片
result+= getDaysRented() * 3;
break;
case Movie.CHILDRENS: //兒童片
result+= 1.5;
if(getDaysRented() > 3)
result+= (getDaysRented() - 3) * 1.5;
break;
}
return result;
}
搬移之后，我就可以開始運(yùn)用Replace Conditional with Polymorphism(255)了。
下面是重構(gòu)前的代碼：
class Price...
double getCharge(int daysRented) {
double result = 0;
switch(getPriceCode()) { //取得影片出租價(jià)格
case Movie.REGULAR: //普通片
result+= 2;
if(getDaysRented() > 2)
result+= (getDaysRented() - 2) * 1.5;
break;
case Movie.NEW_RELEASE: //新片
result+= getDaysRented() * 3;
break;
case Movie.CHILDRENS: //兒童片
result+= 1.5;
if(getDaysRented() > 3)
result+= (getDaysRented() - 3) * 1.5;
break;
}
return result;
}
我的作法是一次取出一個(gè)case分支，在相應(yīng)的class內(nèi)建一個(gè)覆寫函數(shù)(override method)。先從RegularPrice開始：
class RegularPrice...
double getCharge(int daysRented) {
double result = 2;
if(daysRented > 2)
result += (daysRented - 2) * 1.5;
return result;
}
class ChildernsPrice...
double getCharge(int daysRented) {
double result = 1.5;
if(daysRented > 3)
result += (daysRented - 3) * 1.5;
return result;
}
class NewReleasePrice...
double getCharge(int daysRented) {
return daysRented * 3;
}
處理完所有case分支之后，我就把Price.getCharge()聲明為abstract:
class Price...
abstract double getCharge(int daysRented);